Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Homebrew/linuxbrew-core maintainer guide sections #6459

Merged
merged 4 commits into from
Sep 20, 2019

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 15, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Fix a bug where we were using the non-existent $GITHUB_USER envvar
    instead of $HOMEBREW_GITHUB_USER which exists and is used
    elsewhere in the Homebrew codebase.
  • Document the bug where merge PRs don't go green in CI.
  • Document how and when we pull bottles and use brew pull --bottle
    and brew squash-bottle-pr, and also how to recover when you
    accidentally publish a bottle.

This is probably easier to review commit by commit?

@issyl0
Copy link
Member Author

issyl0 commented Sep 19, 2019

Thanks, @MikeMcQuaid and @sjackman. I've made the requested changes.

@MikeMcQuaid MikeMcQuaid merged commit c8390df into Homebrew:master Sep 20, 2019
@MikeMcQuaid
Copy link
Member

thanks again @issyl0!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants